Folder assign fix #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dshabin
commented
May 27, 2021
dshabin
commented
- fix tests
- fix folder assign - unassign
VaghinakDev
approved these changes
May 27, 2021
superannotate/db/project_images.py
Outdated
| project_users = [i['user_id'] for i in project_users] | ||
| verified_contributor = [] | ||
| project_users = [i['id'] for i in project_users] | ||
| unverified_contributor = set(project_users) - set(users) |
Contributor
There was a problem hiding this comment.
Wrong statement, should be users - project_users
davitavagyan
suggested changes
May 28, 2021
Contributor
davitavagyan
left a comment
davitavagyan
left a comment
There was a problem hiding this comment.
I have added comment, please check.
I guess there is not test covering unverified users, please check.
davitavagyan
approved these changes
May 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.